Conversation
…ness Fix 5 critical issues in modal resize functionality: 1. Viewport-aware bounds management - Add window resize listener to recompute effectiveMinSize - Dialog stays within viewport when browser window resizes - Prevents modal from getting stuck off-screen 2. Proper max-size clamping - Respect true maxWidth/maxHeight with 16px margin - Shift or shrink dialog when near viewport edges - No longer forces dialog outside viewport 3. Robust resize state management - Add mouseleave and blur listeners to stop resize - Check event.buttons === 0 in handleResize - Resize reliably stops even if mouseup is lost 4. Smooth performance with RAF batching - Batch cell-size and scrollbar updates into single RAF callback - Eliminate multiple synchronous layout passes - No more jank during fast resize 5. Remove duplicate side-effects - Gate ResizeObserver callback while resizeState is active - Prevent double RAF scheduling - Cleaner control flow All 109 tests passing. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ness
Fix 5 critical issues in modal resize functionality:
Viewport-aware bounds management
Proper max-size clamping
Robust resize state management
Smooth performance with RAF batching
Remove duplicate side-effects
🤖 Generated with Claude Code